feat: update to latest json schema test suite #821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DannyvdSluijs
force-pushed
the
upgrade-json-schema-test-suite
branch
from
45e4b9e to
64ad0c7
Compare
DannyvdSluijs
force-pushed
the
upgrade-json-schema-test-suite
branch
3 times, most recently
from
970acdd to
8875da9
Compare
DannyvdSluijs
force-pushed
the
upgrade-json-schema-test-suite
branch
from
ee860de to
1e458b3
Compare
DannyvdSluijs
force-pushed
the
upgrade-json-schema-test-suite
branch
from
c9ae357 to
b67dc06
Compare
DannyvdSluijs
force-pushed
the
upgrade-json-schema-test-suite
branch
from
b67dc06 to
0ae67f3
Compare
DannyvdSluijs
force-pushed
the
upgrade-json-schema-test-suite
branch
2 times, most recently
from
b6db705 to
04a0263
Compare
DannyvdSluijs
force-pushed
the
upgrade-json-schema-test-suite
branch
3 times, most recently
from
ae4a833 to
5185c14
Compare
DannyvdSluijs
force-pushed
the
upgrade-json-schema-test-suite
branch
from
5185c14 to
5c92ede
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the JSON Schema Test Suite dependency and introduces new test cases for validating JSON schemas. Key changes include dependency upgrades in composer.json, the addition of new test classes (including JsonSchemaTestSuiteTest), and updates to existing test cases and helper methods to support the newer dependency version.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/JsonSchemaTestSuiteTest.php | New test suite to load and run JSON Schema test cases. |
| tests/Drafts/Draft4Test.php & tests/Drafts/Draft3Test.php | Updated draft-based test generators with additional skipped tests. |
| tests/Constraints/VeryBaseTestCase.php | Added a helper to detect 32-bit environments. |
| tests/Constraints/NumberAndIntegerTypesTest.php | Updated test cases with keyed input for clarity. |
| tests/Constraints/BaseTestCase.php | Improved type hints and added custom error messages for validator errors. |
| phpunit.xml.dist | Increased memory limit configuration for tests. |
| composer.json | Upgraded JSON Schema Test Suite dependency to version 23.2.0. |
Comments suppressed due to low confidence (1)
tests/JsonSchemaTestSuiteTest.php:41
- [nitpick] The error message 'Optional test case would during validate() invocation' is ambiguous; consider revising it to clearly indicate that the test case is being skipped due to an exception during validation.
$this->markTestSkipped('Optional test case would during validate() invocation');
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
json-schema/json-schema-test-suitedependency to a newer version and introduces a new test suite for validating JSON schemas. The goal here is to have a quicker turnaround then just the bowtie reports. The most important changes are grouped below:Dependency Updates:
json-schema/json-schema-test-suitedependency incomposer.jsonfrom version1.2.0to^23.2and updated the package version and reference in therepositoriessection to match the new version. [1] [2]New Test Suite:
JsonSchemaTestSuiteclass intests/JsonSchemaTestSuite.phpto run validation tests using thejson-schema/json-schema-test-suite. This includes:testItmethod to validate test cases and assert results.casesDataProvidermethod to dynamically load test cases from thejson-schema-test-suiterepository, skipping certain drafts.loadRemotesIntoStoragehelper method to load remote schemas into the schema storage.